Re: [PATCH 33/50] staging: omap-thermal: refactor APIs handling threshold values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16-03-2013 04:39, Dan Carpenter wrote:
On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote:
  	if (ret) {
  		dev_err(bg_ptr->dev, "failed to read thot\n");
-		return -EIO;
+		ret = -EIO;
+		goto exit;
  	}

-	*thot = temp;
+	*val = temp;

+exit:
  	return 0;
  }


The bunny hop has introduced a bug and this always returns success.

What was the bug introduced?

I will send a patch to fix the return value.


regards,
dan carpenter




--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux