On Fri, Mar 15, 2013 at 09:00:21AM -0400, Eduardo Valentin wrote: > if (ret) { > dev_err(bg_ptr->dev, "failed to read thot\n"); > - return -EIO; > + ret = -EIO; > + goto exit; > } > > - *thot = temp; > + *val = temp; > > +exit: > return 0; > } The bunny hop has introduced a bug and this always returns success. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html