Hi, On Mon, Feb 25, 2013 at 02:21:46PM +0530, Vivek Gautam wrote: > >> @@ -514,6 +511,14 @@ static int dwc3_probe(struct platform_device *pdev) > >> } > >> dwc->mode = mode; > >> > >> +#if IS_ENABLED(CONFIG_USB_DWC3_HOST) > >> + dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_HOST); > >> +#elif IS_ENABLED(CONFIG_USB_DWC3_GADGET) > >> + dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_DEVICE); > >> +#else > >> + dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG); > >> +#endif > > > > you can actually use: > > > > if (IS_ENABLED(CONFIG_USB_DWC3_HOST)) > > dwc3_set_mode(dwc... > > else if (IS_ENABLED( ... > > ... > > else > > ... > > > > I am actually hoping to change this to something like below (after > of course changing the preprocessor conditionals) : > > commit 9a62ed948dcb6ac5d78aff41f5355c0a5ea86475 > Author: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> > Date: Thu Jan 24 11:58:05 2013 +0530 > > usb: dwc3: Set GCTL.PrtCapDir based on selected mode. > > Now that machines may select the mode of working of DWC3, > we can set the Port capability direction based on selected mode. > > Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx> > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 79f335f..9444fbe 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -478,7 +478,13 @@ static int dwc3_probe(struct platform_device *pdev) > goto err1; > } > > - mode = DWC3_MODE(dwc->hwparams.hwparams0); > +#if IS_ENABLED(CONFIG_USB_DWC3_HOST) > + mode = DWC3_MODE_HOST; > +#elif IS_ENABLED(CONFIG_USB_DWC3_GADGET) > + mode = DWC3_MODE_DEVICE; > +#else > + mode = DWC3_MODE_DRD; looks alright. -- balbi
Attachment:
signature.asc
Description: Digital signature
