Re: [PATCH 1/8] ARM: OMAP5: Update SOC id detection code for ES2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 20 February 2013 08:59 PM, Felipe Balbi wrote:
Hi,

On Wed, Feb 20, 2013 at 08:57:07PM +0530, Santosh Shilimkar wrote:
  	case 0xb998:
  		switch (rev) {
  		case 0:
-		default:
  			omap_revision = OMAP5432_REV_ES1_0;
+			break;
+		case 1:
+			omap_revision = OMAP5432_REV_ES2_0;
+			break;
+		default:
+			omap_revision = OMAP5432_REV_ES2_0;

no need for the duplication:

+		case 1:
+		default:
+			omap_revision = OMAP5432_REV_ES2_0;

will work just fine.
right. Will fix that.


  		}
  		break;

  	default:
  		/* Unknown default to latest silicon rev as default*/
-		omap_revision = OMAP5430_REV_ES1_0;
+		omap_revision = OMAP5430_REV_ES2_0;

how about we default to 0xffffffff ? That's the highest possible
version, just not sure if our revision macros can cope with it.

:D
For record, it was decided that we will always have latest silicon
spin as default and hence OMAP5_ES2
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux