Hi Tony,
On 02/01/2013 11:45 PM, Tony Lindgren wrote:
> * Chen Gang <gang.chen@xxxxxxxxxxx> [130130 03:50]:
>>
>> the fields must be null-terminated:
>> the caller may use it as null-terminted string, next.
>
> Added Peter to cc on this one too, it's best that he queues
> all the twl changes.
I can create a branch for you in our gitorious tree
(git://gitorious.org/omap-audio/linux-audio.git) for this patch. But I think
for now it would be best if you could take this via linux-omap (the file is
under arch/arm/mach-omap2 anyways)
Regards,
Péter
>
> Tony
>
>> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
>> ---
>> arch/arm/mach-omap2/twl-common.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c
>> index e49b40b..6a7aec6 100644
>> --- a/arch/arm/mach-omap2/twl-common.c
>> +++ b/arch/arm/mach-omap2/twl-common.c
>> @@ -23,6 +23,7 @@
>> #include <linux/i2c.h>
>> #include <linux/i2c/twl.h>
>> #include <linux/gpio.h>
>> +#include <linux/string.h>
>> #include <linux/regulator/machine.h>
>> #include <linux/regulator/fixed.h>
>>
>> @@ -56,7 +57,7 @@ void __init omap_pmic_init(int bus, u32 clkrate,
>> struct twl4030_platform_data *pmic_data)
>> {
>> omap_mux_init_signal("sys_nirq", OMAP_PIN_INPUT_PULLUP | OMAP_PIN_OFF_WAKEUPENABLE);
>> - strncpy(pmic_i2c_board_info.type, pmic_type,
>> + strlcpy(pmic_i2c_board_info.type, pmic_type,
>> sizeof(pmic_i2c_board_info.type));
>> pmic_i2c_board_info.irq = pmic_irq;
>> pmic_i2c_board_info.platform_data = pmic_data;
>> --
>> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
