Mugunthan V N <mugunthanvnm@xxxxxx> : > On 1/31/2013 3:32 AM, Francois Romieu wrote: [...] > > It could be factored out. > Are you mentioning to have static inline function for the above two > statements above? Yes. The helper function does not need to be inlined if it does not save space: this path is not performance critical. [...] > >Patch #2 doesn't use the returned status code. > Will modify the prototype to return void :o( The driver should notify the upper layers that the request failed instead of hiding the stuff under the carpet. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html