Re: [PATCH v1 4/6] drivers: usb: musb: omap: make use of the new PHY lib APIs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tuesday 22 January 2013 07:39 PM, Roger Quadros wrote:
On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote:
New PHY lib APIs like usb_add_phy_dev() and devm_usb_get_phy_dev() are
used in MUSB (OMAP), in order to make use of the binding information
provided in the board file (of OMAP platforms).
All the platforms should be modified similar to this to add and get the
PHY.

Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
---
  drivers/usb/musb/omap2430.c   |    2 +-
  drivers/usb/otg/twl4030-usb.c |    3 ++-
  drivers/usb/phy/omap-usb2.c   |    3 ++-
  3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index bf6cfe0..1a8cf6d 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -345,7 +345,7 @@ static int omap2430_musb_init(struct musb *musb)
  	 * up through ULPI.  TWL4030-family PMICs include one,
  	 * which needs a driver, drivers aren't always needed.
  	 */
-	musb->xceiv = devm_usb_get_phy(dev, USB_PHY_TYPE_USB2);
+	musb->xceiv = devm_usb_get_phy_dev(dev, 0);
  	if (IS_ERR_OR_NULL(musb->xceiv)) {
  		pr_err("HS USB OTG: no transceiver configured\n");
  		return -ENODEV;
diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c
index 0a70193..a994715 100644
--- a/drivers/usb/otg/twl4030-usb.c
+++ b/drivers/usb/otg/twl4030-usb.c
@@ -610,6 +610,7 @@ static int twl4030_usb_probe(struct platform_device *pdev)
  	twl->phy.dev		= twl->dev;
  	twl->phy.label		= "twl4030";
  	twl->phy.otg		= otg;
+	twl->phy.type		= USB_PHY_TYPE_USB2;

What is the need to set phy.type? I think this should be deprecated along with the old API.

The *type* field as such is not deprecated. Adding and getting a PHY using *type* is deprecated.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux