Hi, On Fri, Dec 14, 2012 at 08:04:27PM +1100, NeilBrown wrote: > this commit: > > commit c9721438c009adf8e81d376839ed037c53b9b8d9 > Author: Kishon Vijay Abraham I <kishon@xxxxxx> > Date: Fri Jun 22 17:40:52 2012 +0530 > > usb: musb: twl: use mailbox API to send VBUS or ID events > > The atomic notifier from twl4030/twl6030 to notifiy VBUS and ID events, > is replaced by a direct call to omap musb blue. > > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > Seems to have broken twl4030_charger.c. > This code relies on the notifier to know when the USB has been plugged in and > so it should consider enabling the charger. > > now that the notification has gone, the charger never turns on. > > If I put the atomic_notifier_call_chain() calls back in, then the charger is > activated as appropriate. > > What is the plan here? Should the calls go back, or is there some way for > twl4030_charger to hook into the "mailbox"? Or is there some other way it > should work? hmmm, tricky situation. Maybe we add back the notifer calls but keep the mailbox API ? -- balbi
Attachment:
signature.asc
Description: Digital signature
