On Thu, Dec 13, 2012 at 02:32:46PM +0000, Guennadi Liakhovetski wrote: > On Thu, 13 Dec 2012, Will Deacon wrote: > > > On Thu, Dec 13, 2012 at 08:09:33AM +0000, Guennadi Liakhovetski wrote: > > > On Wed, 12 Dec 2012, Will Deacon wrote: > > > > Back to the case in hand.... Lorenzo just pointed out to me that the > > > > finished in question (sh7372_do_idle_sysc) calls v7_flush_dcache_all, so > > > > the louis stuff should be irrelevant. The problem may actually be that the > > > > finisher disables the L2 cache prior to cleaning/invalidating it, which is > > > > the opposite order to that described by the A8 TRM. > > > > > > > > Guennadi -- can you try moving the kernel_flush call before the L2 disable > > > > in sh7372_do_idle_sysc please? > > > > > > Yes, this works too. > > > > That's good to know. Please can you send a patch for that? The sequence > > currently being used by the finisher *is* buggy, and should be fixed > > independently of the louis stuff. > > Well, the fix is yours, so, it should be "From: you." I can certainly send > it just copying your description above, but I'd also need your Sob. > Something like the below (feel free to improve the subject line and the > description): No, I didn't send any code for this so you should be the author. I can review/possibly ack it if you like (please send a v2 addressing Santosh's comments). Will -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
