On 12/03/2012 09:48 AM, Bjørn Mork wrote: > Sergei Shtylyov <sshtylyov@xxxxxxxxxx> writes: >> On 28-11-2012 18:49, Roger Quadros wrote: >>> ret = clk_set_parent(omap->utmi_clk[0], >>> omap->xclk60mhsp1_ck); >>> if (ret != 0) >>> - dev_err(dev, "xclk60mhsp1_ck set parent" >>> + dev_dbg(dev, "xclk60mhsp1_ck set parent" >> >> Need space at the end of this substring, else you get "parentfailed" >> >>> "failed error:%d\n", ret); > > > Wouldn't it be better to change all these to conform with > Documentation/CodingStyle when touching them anyway? That would make > the missing space problem obvious as well as making the messages > greppable. > > From Chapter 2: Breaking long lines and strings: > > "However, never break user-visible strings such as printk messages, > because that breaks the ability to grep for them." > Agreed. I'll fix it in next spin. Thanks. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
