Re: [PATCH v2 22/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 28-11-2012 18:49, Roger Quadros wrote:

clk_set_parent is expected to fail on OMAP3 platforms. We don't
consider that as fatal so don't spam console.

Signed-off-by: Roger Quadros <rogerq@xxxxxx>
---
  drivers/mfd/omap-usb-host.c |   10 +++++-----
  1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 6ede319..493e010 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -653,17 +653,17 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
  	}

  	if (is_ehci_phy_mode(pdata->port_mode[0])) {
-		/* for OMAP3 , the clk set paretn fails */
+		/* for OMAP3 , the clk set parent fails */

   Worth removing spave before comma too.

  		ret = clk_set_parent(omap->utmi_clk[0],
  					omap->xclk60mhsp1_ck);
  		if (ret != 0)
-			dev_err(dev, "xclk60mhsp1_ck set parent"
+			dev_dbg(dev, "xclk60mhsp1_ck set parent"

   Need space at the end of this substring, else you get "parentfailed"

  				"failed error:%d\n", ret);
  	} else if (is_ehci_tll_mode(pdata->port_mode[0])) {
  		ret = clk_set_parent(omap->utmi_clk[0],
  					omap->init_60m_fclk);
  		if (ret != 0)
-			dev_err(dev, "init_60m_fclk set parent"
+			dev_dbg(dev, "init_60m_fclk set parent"

   Same here.

  				"failed error:%d\n", ret);
  	}

@@ -671,13 +671,13 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
  		ret = clk_set_parent(omap->utmi_clk[1],
  					omap->xclk60mhsp2_ck);
  		if (ret != 0)
-			dev_err(dev, "xclk60mhsp2_ck set parent"
+			dev_dbg(dev, "xclk60mhsp2_ck set parent"

   Same here.

  					"failed error:%d\n", ret);
  	} else if (is_ehci_tll_mode(pdata->port_mode[1])) {
  		ret = clk_set_parent(omap->utmi_clk[1],
  						omap->init_60m_fclk);
  		if (ret != 0)
-			dev_err(dev, "init_60m_fclk set parent"
+			dev_dbg(dev, "init_60m_fclk set parent"

   And here.

  				"failed error:%d\n", ret);

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux