On Wed, 21 Nov 2012, Felipe Balbi wrote: > On Thu, Nov 15, 2012 at 04:34:14PM +0200, Roger Quadros wrote: > > From: Andy Green <andy.green@xxxxxxxxxx> > > > > This patch changes the management of the two GPIO for > > "hub reset" (actually controls enable of ULPI PHY and hub reset) and > > "hub power" (controls power to hub + eth). > > looks like this should be done by the hub driver. Alan, what would you > say ? Should the hub driver know how to power itself up ? Not knowing the context, I'm a little confused. What is this hub you're talking about? Is it a separate USB hub incorporated into the IP (like Intel's "rate-matching" hubs in their later chipsets)? Or is it the root hub? Under what circumstances would the hub not be powered (i.e., when is it not in use)? If it isn't powered, can it be suspended? Or enumerated? Is this the sort of thing that should be handled by a PM domain? As much as possible, the hub driver tries to ignore the differences between root hubs and non-root hubs. So for example, all hubs have to be told to turn on VBUS power to their ports; therefore the hub driver tells them. But external hubs are either self-powered or bus-powered; there's no need and no way for the hub driver to turn the hub power on or off. Therefore it doesn't try, not even for root hubs. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
