On 11/16/2012 05:44 PM, Joel A Fernandes wrote:
> Set ENABLE_ON_INIT for debugss clock so that it is on during init and the usecount is incremented.
> Not doing so causes kernel to disable debugss clock to save power when CONFIG_OMAP_RESET_CLOCKS
> is set, causing a JTAG disconnect.
>
> Signed-off-by: Joel A Fernandes <joelagnel@xxxxxx>
> Cc: Russ Dill <Russ.Dill@xxxxxx>
> Cc: Matt Porter <mporter@xxxxxx>
> Cc: Steve Kipisz <s-kipisz2@xxxxxx>
> Cc: Jason Kridner <jkridner@xxxxxxxxxxxxxxx>
> Cc: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> Resending, as Cc list was dropped.
>
> arch/arm/mach-omap2/clock33xx_data.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c
> index b7b7995..d0b4313 100644
> --- a/arch/arm/mach-omap2/clock33xx_data.c
> +++ b/arch/arm/mach-omap2/clock33xx_data.c
> @@ -585,6 +585,7 @@ static struct clk debugss_ick = {
> .clkdm_name = "l3_aon_clkdm",
> .parent = &dpll_core_m4_ck,
> .ops = &clkops_omap2_dflt,
> + .flags = ENABLE_ON_INIT,
> .enable_reg = AM33XX_CM_WKUP_DEBUGSS_CLKCTRL,
> .enable_bit = AM33XX_MODULEMODE_SWCTRL,
> .recalc = &followparent_recalc,
Does this mean this clock will always be enabled, even when not using
JTAG? If so, is that what you want?
I was not sure if you are concerned about power at all. Or if having
that always enabled can inhibit low power states for suspend/idle etc.
May be worth adding more details to the changelog about if there are
side-effects to this change or not.
Adding Paul as he is the maintainer of clocks and clock data.
Cheers
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
