Re: [PATCH v2 00/26] Move OMAP2+ over to common clk framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Laurent Pinchart (2012-11-13 05:42:35)
> Hi Mike,
> 
> Thank you for the patches.
> 
> On Wednesday 07 November 2012 17:12:35 Mike Turquette wrote:
> > From: Mike Turquette <mturquette@xxxxxxxxxx>
> > 
> > Hi all,
> > 
> > This series is based on top of Paul's PRM/CM clean-up work.  It is a
> > refresh of the patches Rajendra sent out a while back[1], with the
> > addition of several fixes for PM regressions[2] across several
> > platforms.
> > 
> > I have tested on OMAP4430 Panda including PRCM diffing against pre-CCF
> > patches (delta is zero) and also suspend/resume.
> > 
> > I also tested on OMAP4460 Panda-ES.  Boot is fine and PRCM programming
> > appears sane.  However Panda-ES never comes back from suspend/resume.
> > This problem exists on the PRM/CM branch I based on and was not
> > introduced by this series.  I am investigating that independently of
> > this series.
> > 
> > Anyone wanting to pull the work can find it at:
> > git://git.linaro.org/people/mturquette/linux.git clk-omap-3.8
> > 
> > [1] http://article.gmane.org/gmane.linux.ports.arm.omap/78771
> > [2] http://article.gmane.org/gmane.linux.ports.arm.omap/84015
> 
> I've tested the whole series on a Beagleboard-xM. The kernel boots fine but 
> spits a couple of WARN_ON due to missing clk_prepare in USB-related drivers. I 
> haven't noticed any regression in the OMAP3 ISP driver.
> 

Those drivers need to be fixed.  Can you provide a log?

> I've also successfully tested rate back-propagation (CLK_SET_RATE_PARENT) on 
> the dpll4_m5x2_ck and cam_mclk clocks with the OMAP3 ISP driver. I'll send a 
> patch for that on top of your v3.
> 

It is great to see this feature in action.  Do you think the OMAP3 ISP
driver can have parent clock info removed?  The goal of the
CLK_SET_RATE_PARENT flag is to make life easier for drivers by not
having to know the details of the clock tree topology.

> So,
> 
> Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> 

Thanks for testing!

Regards,
Mike

> -- 
> Regards,
> 
> Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux