Hi, On Wed, Oct 31, 2012 at 03:02:57PM +0530, Shubhrajyoti Datta wrote: > On Wed, Oct 31, 2012 at 2:29 PM, Shubhrajyoti D <shubhrajyoti@xxxxxx> wrote: > > The revision register on OMAP4 is a 16-bit lo and a 16-bit > > hi. Currently the driver reads only the lower 8-bits. > > Fix the same by preventing the truncating of the rev register > > for OMAP4. > > > > Also use the scheme bit ie bit-14 of the hi register to know if it > > is OMAP_I2C_IP_VERSION_2. > > > > On platforms previous to OMAP4 the offset 0x04 is IE register whose > > bit-14 reset value is 0, the code uses the same to its advantage. > > > > The dev->regs is populated after reading the rev_hi. A NULL check > > has been added in the resume handler to prevent the access before > > the setting of the regs. > > > tested on omap4sdp, omap3630 based beagle , omap3430sdp. oh, now I see. You need to test on OMAP2 which has different revision layout. -- balbi
Attachment:
signature.asc
Description: Digital signature
