Hi Tero, On Tue, 23 Oct 2012, Tero Kristo wrote: > Looks good to me. Only reason I pushed the reset wait to the end of the > function was a minimal potential timing optimization. As the beginning > of the function will write a register, it will consume a bit of time > (especially if in 32k domain), so it can maybe save a single register > read in the delay loop if ordered that way. Ah, OK. > Your way is probably safer, it might cause problems in some cases if the > config is written before reset has completed (can it?) Not sure, but seems to make sense to wait until the reset is done before doing anything to the IP block's registers. Queuing for 3.7-rc fixes, - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html