On Wednesday 24 October 2012 07:49 PM, Kevin Hilman wrote:
Grazvydas Ignotas <notasas@xxxxxxxxx> writes:
On Tue, Oct 23, 2012 at 9:09 PM, Kevin Hilman
<khilman@xxxxxxxxxxxxxxxxxxx> wrote:
From: Kevin Hilman <khilman@xxxxxx>
When debounce clocks are disabled, ensure that the banks
dbck_enable_mask is cleared also. Otherwise, context restore on
subsequent off-mode transition will restore previous value from the
shadow copies (bank->context.debounce*) leading to mismatch state
between driver state and hardware state.
This doesn't look right to me, aren't you effectively disabling
debounce forever here? _gpio_dbck_disable is called from
omap_gpio_runtime_suspend() and nothing will ever restore
dbck_enable_mask back to what it was set by _set_gpio_debounce and
debounce functionality is lost.
Yes, you're right. Good catch.
I need a fix that's more targetted to the free/reset path.
Right. Just clearing the debounce mask in omap_gpio_free()
should do the trick.
Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
