On Tue, Oct 23, 2012 at 8:09 PM, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: > From: Kevin Hilman <khilman@xxxxxx> > > When debounce clocks are disabled, ensure that the banks > dbck_enable_mask is cleared also. Otherwise, context restore on > subsequent off-mode transition will restore previous value from the > shadow copies (bank->context.debounce*) leading to mismatch state > between driver state and hardware state. > > This was discovered when board code was doing > > gpio_request_one() > gpio_set_debounce() > gpio_free() > > which was leaving the GPIO debounce settings in a confused state. > Then, enabling off mode causing bogus state to be restored, leaving > GPIO debounce enabled which then prevented the CORE powerdomain from > transitioning. > > Reported-by: Paul Walmsley <paul@xxxxxxxxx> > Cc: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> > Signed-off-by: Kevin Hilman <khilman@xxxxxx> Thanks! Applied with Felipe's and Santosh's ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
