* Tony Lindgren <tony@xxxxxxxxxxx> [121016 11:12]: > * Ohad Ben-Cohen <ohad@xxxxxxxxxx> [121014 11:32]: > > On Fri, Oct 12, 2012 at 6:24 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > >> Error setting wl12xx data: -38 > > .. > > > Ohad, can you please take a look? > > > > Sure, -38 is -ENOSYS which is returned when the wl12xx driver isn't configured. > > > > This isn't an error (it's a user decision, and it shouldn't elicit any > > error) and the patch below (also attached) should make it go away on: > > > > From 374f145568585c8d6a8d5e4b8b5d3e6baedd2f39 Mon Sep 17 00:00:00 2001 > > From: Ohad Ben-Cohen <ohad@xxxxxxxxxx> > > Date: Sun, 14 Oct 2012 20:16:01 +0200 > > Subject: [PATCH] ARM: OMAP: don't print any error when wl12xx isn't > > configured > > > > Stop intimidating users with scary wlan error messages in case wl12xx > > support wasn't even built. > > > > In addition, when wl12xx_set_platform_data() fails, don't bother > > registering wl12xx's fixed regulator device (on the relevant > > boards). > > > > While we're at it, extract the wlan init code to a dedicated function to > > make (the relevant boards') init code look a bit nicer. > > > > Reported-by: Russell King <linux@xxxxxxxxxxxxxxxx> > > Signed-off-by: Ohad Ben-Cohen <ohad@xxxxxxxxxx> > > Thanks applying into omap-for-v3.7-rc1/fixes-part2. Hmm looking at it repeats the same code over again. Can you rather add some wl12xx_board_init() helper function to mach-omap2/devices.c to do it? Dropping this for now. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
