On 10/16/2012 03:27 AM, Ricardo Neri wrote:
> Creating the accessory devices, such as audio, from the HDMI driver
> allows to regard HDMI as a single entity with audio an display
> functionality. This intends to follow the design of drivers such
> as MFD, in which a single entity handles the creation of the accesory
> devices. Such devices are then used by domain-specific drivers; audio in
> this case.
>
> Also, this is in line with the DT implementation of HDMI, in which we will
> have a single node to describe this feature of the OMAP SoC.
...
> + hdmi_aud_res[HDMI_AUDIO_MEM_RESOURCE].start = res->start;
> + hdmi_aud_res[HDMI_AUDIO_MEM_RESOURCE].end = res->end;
> + hdmi_aud_res[HDMI_AUDIO_MEM_RESOURCE].flags = IORESOURCE_MEM;
> +
> + res = platform_get_resource(hdmi.pdev, IORESOURCE_DMA, 0);
> + if (!res) {
> + DSSERR("can't get IORESOURCE_DMA HDMI\n");
> + return -EINVAL;
> + }
> +
> + /* Pass this resource to audio_pdev */
> + hdmi_aud_res[HDMI_AUDIO_DMA_RESOURCE].start = res->start;
> + hdmi_aud_res[HDMI_AUDIO_DMA_RESOURCE].end = res->end;
> + hdmi_aud_res[HDMI_AUDIO_DMA_RESOURCE].flags = IORESOURCE_DMA;
> +
> + /* create platform device for HDMI audio driver */
> + hdmi.audio_pdev = platform_device_register_simple(
> + "omap_hdmi_audio",
> + -1, hdmi_aud_res,
> + ARRAY_SIZE(hdmi_aud_res));
Should you also update arch/arm/mach-omap2/devices.c to not register the same
device?
When we do not boot with DT devices.c will create the same device earlier
(without pdata) which will prevent this device to be created and at the end
will prevent omap_hdmi_audio driver to probe due to missing pdata...
> + if (IS_ERR(hdmi.audio_pdev)) {
> + DSSERR("Can't instantiate hdmi-audio\n");
> + return PTR_ERR(hdmi.audio_pdev);
> + }
> +
> + return 0;
> +}
> +
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
