Hi, Laurent!
Thanks for the comments!
On Tue, Oct 09, 2012 at 02:17:48AM +0200, Laurent Pinchart wrote:
...
> > @@ -32,6 +32,92 @@
> > #include "ispreg.h"
> > #include "ispcsiphy.h"
> >
> > +static void csiphy_routing_cfg_3630(struct isp_csiphy *phy, u32 iface,
> > + bool ccp2_strobe)
> > +{
> > + u32 cam_phy_ctrl =
>
> If you call the variable "value" or "ctrl" two statements below could fit on
> one line, but that's up to you :-)
I'll call it "reg". :)
> > + isp_reg_readl(phy->isp,
> > + OMAP3_ISP_IOMEM_3630_CONTROL_CAMERA_PHY_CTRL, 0);
> > + u32 shift, mode;
> > +
> > + switch (iface) {
> > + case ISP_INTERFACE_CCP2B_PHY1:
> > + cam_phy_ctrl &=
> > + ~OMAP3630_CONTROL_CAMERA_PHY_CTRL_CSI1_RX_SEL_PHY2;
> > + shift = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_PHY1_SHIFT;
> > + break;
> > + case ISP_INTERFACE_CSI2C_PHY1:
> > + shift = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_PHY1_SHIFT;
> > + mode = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_DPHY;
> > + break;
> > + case ISP_INTERFACE_CCP2B_PHY2:
> > + cam_phy_ctrl |=
> > + OMAP3630_CONTROL_CAMERA_PHY_CTRL_CSI1_RX_SEL_PHY2;
> > + shift = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_PHY2_SHIFT;
> > + break;
> > + case ISP_INTERFACE_CSI2A_PHY2:
> > + shift = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_PHY2_SHIFT;
> > + mode = OMAP3630_CONTROL_CAMERA_PHY_CTRL_CAMMODE_DPHY;
> > + break;
> > + default:
> > + pr_warn("bad iface %d\n", iface);
>
> As you already know, dev_warn() is a better idea. Can this actually happen ?
I don't think so; it's checked in isp.c in isp_register_entities().. I'll
remove it.
Cheers.
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
