Re: [PATCH] arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25.09.2012 02:37, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [120924 16:17]:
>> On Mon, Sep 24, 2012 at 09:05:11PM +0200, Yegor Yefremov wrote:
>>> On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>>>> * yegorslists@xxxxxxxxxxxxxx <yegorslists@xxxxxxxxxxxxxx> [120703 07:26]:
>>>>> From: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
>>>>>
>>>>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>>>>> of consistent DMA memory (da8xx frame buffer driver).
>>>>
>>>> Sorry for the delay on this one, looks like this one is
>>>> still valid. I'll apply it.
>>>
>>> Thanks.
>>>
>>> Yegor
>>>
>>>>> Signed-off-by: Dejan Gacnik <dejan.gacnik@xxxxxxxxx>
>>>>> Signed-off-by: Yegor Yefremov <yegorslists@xxxxxxxxxxxxxx>
>>>>> ---
>>>>>  arch/arm/Kconfig |    5 +++--
>>>>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>>>> index e876819..ff14c1e 100644
>>>>> --- a/arch/arm/Kconfig
>>>>> +++ b/arch/arm/Kconfig
>>>>> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
>>>>>  source "mm/Kconfig"
>>>>>
>>>>>  config FORCE_MAX_ZONEORDER
>>>>> -     int "Maximum zone order" if ARCH_SHMOBILE
>>>>> -     range 11 64 if ARCH_SHMOBILE
>>>>> +     int "Maximum zone order"
>>>>> +     depends on ARCH_SHMOBILE || SOC_AM33XX
>>>>> +     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>>>>>       default "9" if SA1111
>>>>>       default "11"
>>
>> NAK.  This patch breaks SA1111 platforms.  To see why, read the patch.
> 
> OK let's drop this.

How should I change the patch to make it proper? SA1111 is broken anyway:

config FORCE_MAX_ZONEORDER
        int "Maximum zone order" if ARCH_SHMOBILE
        range 11 64 if ARCH_SHMOBILE
        default "9" if SA1111
        default "11"

AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE, so SA1111 won't be evaluated (at least if I select SA1111 include/generated/autoconf.h shows "11"). If I add SA1111 to dependency list like this:

depends on ARCH_SHMOBILE || SOC_AM33XX || SA1111

the prompt in "Kernel features" becomes visible, but it doesn't have the default value of "9", but "11".

Am I missing something?

Yegor
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux