Hi Felipe, On Friday 21 September 2012 20:37:40 Felipe Contreras wrote: > On Wed, Sep 19, 2012 at 2:06 PM, Laurent Pinchart wrote: > > VMAs marked with the VM_PFNMAP flag have no struct page associated with > > the memory PFNs. Don't call get_page()/put_page() on the pages > > supposedly associated with the PFNs. > > I don't see anything wrong with the patch, but I think there's a lot > of changes, and perhaps a bit more of explanation of how it's doing > this might help. I'll make the commit message more explicit. > Also, it seems to be reordering match_exact_map_obj(), which messes up the > diff a bit. That's because match_exact_map_obj() logically belonged to remove_mapping_information(), but now belongs to find_dsp_mapping(). I've split the commit in two, I'll send the result in reply to this e-mail. Please let me know if you like that better. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html