Hi Kevin, On Thu, Sep 20, 2012 at 3:13 AM, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: > "Poddar, Sourav" <sourav.poddar@xxxxxx> writes: > >> Hi Felipe, >> >> On Tue, Sep 18, 2012 at 5:04 PM, Felipe Balbi <balbi@xxxxxx> wrote: >>> On Tue, Sep 18, 2012 at 05:05:54PM +0530, Sourav Poddar wrote: >>>> Drop the check for "up" being valid on suspend/resume callbacks. >>>> It should be valid always. Get rid of the "pdata" check also as >>>> serial_omap_get_context_loss_count() checks for it. >>>> >>>> Tested on omap4 panda and 3630 based Beagle board. >>> >>> you need a blank line here. Other than that: >>> >>> Reviewed-by: Felipe Balbi <balbi@xxxxxx> >>> >>> ps: what kind of tests did you run, btw ? >>> >> Boot tested on Panda. >> Boot and PM tested(hitiing Off) on Beagle. > > What does "PM tested" mean. hitting off in idle? hitting off in > suspend? both? > Hitting off in both idle and suspend. > Please clarify. > > Thanks, > > Kevin ~Sourav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html