Hi,
* Jean Pihet <jean.pihet@xxxxxxxxxxxxxx> [120920 07:48]:
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -131,14 +131,11 @@ static void sr_set_clk_length(struct omap_sr *sr)
> struct clk *sys_ck;
> u32 sys_clk_speed;
>
> - if (cpu_is_omap34xx())
> - sys_ck = clk_get(NULL, "sys_ck");
> - else
> - sys_ck = clk_get(NULL, "sys_clkin_ck");
> + sys_ck = clk_get(NULL, sr->fck_name);
>
> if (IS_ERR(sys_ck)) {
> - dev_err(&sr->pdev->dev, "%s: unable to get sys clk\n",
> - __func__);
> + dev_err(&sr->pdev->dev, "%s: unable to get smartreflex fck %s\n",
> + __func__, sr->fck_name);
> return;
> }
>
You should be able to make this even simpler and not have to pass
the clock name around at all. Just do:
syc_ck = clk_get(NULL, "fck);
...
In the driver, and add the necessary entries to the clock alias
table. That way it's up to the SoC to set up the necessary clocks
and the driver stays generic.
> @@ -1049,6 +1039,7 @@ static int __devexit omap_sr_remove(struct platform_device *pdev)
>
> list_del(&sr_info->node);
> iounmap(sr_info->base);
> + kfree(sr_info->fck_name);
> kfree(sr_info->name);
> kfree(sr_info);
> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Then there's no need for the kfree of the fck_name
either.
There's an example of a similar patch done for twl-core.c as commit
defa6be1 (mfd: Fix compile for twl-core.c by removing cpu_is_omap usage)
in current linux next, except with smartreflex you probably don't
need to do any of the platform_device_alloc trickery like twl-core.c
neded to get around using the i2c numbers as names.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
