Re: [PATCH 1/2] gpio/twl4030: get platform data from device tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Benoit,


I fixed them since it was trivial, but next time you should ensure
that the patch pass checkpatch before posting.
Sorry for these errors. I however checked my patches before submitting,
and had no such warnings. I redone, and remarked that these warnings
appear only with the "--strict" option, which is not enabled by default.
Is this the recommended  guideline? Thus why not enabling it by default?
That's a pretty good question :-)

Maybe the --strict is more a nice to have than a strong requirement?
Anyway, we'd better run checkpatch with --strict and thus fix any
cosmetic details that might be in the patch.

Good to know, I will use --strict for the next submissions.

Cool, I love chocolate. That being said, I'm not sure how tasteful will be the *virtual* chocolate. Regards, Benoit

Even *virtual*, Swiss chocolate will be the most tasteful (hope no Belgium
friends will see this thread) :-)

Regards,
Florian

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux