Hi Mark, On Mon, Sep 10, 2012 at 07:33:34AM +0800, Mark Brown wrote: > On Sun, Sep 09, 2012 at 09:12:40PM +0200, Uwe Kleine-König wrote: > > On Sat, Sep 08, 2012 at 09:38:49AM +0100, Russell King - ARM Linux wrote: > > > > > of: add const to struct *of_device_id.data > > > > > > > > Drivers should never need to modify the data of a device id. So it can > > > > be const which in turn allows more consts in the driver. > > > > I notice this one is still present in the kernel. Uwe, what's happening > > > with it? > > > Yeah, the warning was introduced by my patch. It's not trivial to fix > > because the twl-regulator driver modifies the data used to probe devices > > during probe. That is the result of two probes might depend on their > > order. I mentioned that problem in the cover letter of my series but got > > no feedback from someone feeling responsible for this driver. > > Arnd sent a patch for that problem, don't know its state though. > > I don't recall such a patch being sent to me. The twl-regulator driver > is unmaintained so it's unlikely anyone is going to actively work on it. Message-id: 201208141241.51379.arnd@xxxxxxxx Mark, you even replied that you applied it!? It wasn't sent to a mailing list though. Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
