Re: New build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Sep 08, 2012 at 09:38:49AM +0100, Russell King - ARM Linux wrote:
> On Mon, Jul 30, 2012 at 05:44:44PM +0100, Russell King - ARM Linux wrote:
> > Okay, so last night's build run shows some new warnings...
> > 
> > drivers/regulator/twl-regulator.c: In function 'twlreg_probe':
> > drivers/regulator/twl-regulator.c:1151: warning: assignment discards qualifiers from pointer target type
> > drivers/regulator/twl-regulator.c:1160: warning: assignment discards qualifiers from pointer target type
> > 
> > These two look like missing const - looks like they were introduced by:
> > 
> > commit 98d7bbb9929bcc14e11ac8a55245a4f2dc174e17
> > Author: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> > Date:   Thu Jun 7 12:20:14 2012 +0200
> > 
> >     of: add const to struct *of_device_id.data
> > 
> >     Drivers should never need to modify the data of a device id. So it can
> >     be const which in turn allows more consts in the driver.
> > 
> >     Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> >     Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> I notice this one is still present in the kernel.  Uwe, what's happening
> with it?
Yeah, the warning was introduced by my patch. It's not trivial to fix
because the twl-regulator driver modifies the data used to probe devices
during probe. That is the result of two probes might depend on their
order. I mentioned that problem in the cover letter of my series but got
no feedback from someone feeling responsible for this driver.
Arnd sent a patch for that problem, don't know its state though.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux