Re: [PATCH 0/3] gpio-twl4030: add new device tree properties

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Benoit,

Nit #2: the DTS file does not belong to the gpio subsystem. So you
should prefix them using the *convention* for ARM DTS patches:

arm/dts: omap3: Add gpio-twl4030 properties for BeagleBoard and omap3-EVM

Or maybe "ARM: dts: " because it looks like most people are using that
nowadays.

The convention for the gpio directory is similar:
gpio/twl4030: get platform data from device tree

   gpio-twl4030: updates the bindings for new dt properties

  .../devicetree/bindings/gpio/gpio-twl4030.txt      |    6 ++
  arch/arm/boot/dts/omap3-beagle.dts                 |   20 +++++
  arch/arm/boot/dts/omap3-evm.dts                    |   13 +++
  drivers/gpio/gpio-twl4030.c                        |   86 +++++++++++++------
  4 files changed, 98 insertions(+), 27 deletions(-)
Thanks,
Benoit

Thank you for your review, I will send a new version soon.

Regards,
Florian

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux