On Tue, Aug 21, 2012 at 3:54 PM, Felipe Balbi <balbi@xxxxxx> wrote:
> On Tue, Aug 21, 2012 at 03:11:51PM +0530, Shilimkar, Santosh wrote:
>> On Mon, Aug 20, 2012 at 9:21 PM, Shilimkar, Santosh
>> <santosh.shilimkar@xxxxxx> wrote:
>> > On Mon, Aug 20, 2012 at 7:21 PM, Benoit Cousson <b-cousson@xxxxxx> wrote:
>> >> Hi Santosh,
>> >>
>> >> On 08/13/2012 01:00 PM, Santosh Shilimkar wrote:
>> >>> This provides PL310 Level 2 Cache Controller Device Tree
>> >>> support for OMAP4 based devices.
>> >>>
>> >>> Cc: Benoit Cousson <b-cousson@xxxxxx>
>> >>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>> >>> ---
>> >>> arch/arm/boot/dts/omap4.dtsi | 7 +++++++
>> >>> arch/arm/mach-omap2/omap4-common.c | 6 +++++-
>> >>> 2 files changed, 12 insertions(+), 1 deletion(-)
>> >>>
>> >>> diff --git a/arch/arm/boot/dts/omap4.dtsi b/arch/arm/boot/dts/omap4.dtsi
>> >>> index 6717c71..cf1efb6 100644
>> >>> --- a/arch/arm/boot/dts/omap4.dtsi
>> >>> +++ b/arch/arm/boot/dts/omap4.dtsi
>> >>> @@ -36,6 +36,13 @@
>> >>> };
>> >>> };
>> >>>
>> >>
>> >>> + L2: l2-cache-controller {
>> >>
>> >> The reg offset is missing: l2-cache-controller@48242000
>> >>
>> >>> + compatible = "arm,pl310-cache";
>> >>> + reg = <0x48242000 0x1000>;
>> >>> + cache-unified;
>> >>> + cache-level = <2>;
>> >>> + };
>> >>> +
>> >>
>> >> In theory, the L2 cache should be referenced from the CPUs.
>> >>
>> > Agree.
>> >
>> I have added the reference for the L2 controller in CPUs.
>> Other information like L1 cache size etc can be added in cpu
>> DT node with another patch.
>>
>> Updated patch below. Have also updated git branch
>> accordingly.
>>
>> Regards
>> Santosh
>>
>> From 91d6cb4f999061c8cfc844a3916ee3384f2e488a Mon Sep 17 00:00:00 2001
>> From: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>> Date: Wed, 4 Jul 2012 17:57:34 +0530
>> Subject: [PATCH 1/2 v2] ARM: OMAP4: Add L2 Cache Controller in Device Tree
>>
>> This provides PL310 Level 2 Cache Controller Device Tree
>> support for OMAP4 based devices.
>>
>> Cc: Benoit Cousson <b-cousson@xxxxxx>
>> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
>
> nice work :-)
>
> FWIW this looks good to me:
>
> Acked-by: Felipe Balbi <balbi@xxxxxx>
>
Thanks.
> just one thing, will a similar patch for omap3 be sent ?
>
OMAP3 has an integrated L2 cache controller so there
won't any additional DT node for L2.
OMAP3 CPU DT node can be updated with l1/l2 cache
size etc related information though.
Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
