Hi Benoit, On 20 August 2012 09:49, Benoit Cousson <b-cousson@xxxxxx> wrote: > On 07/16/2012 09:21 PM, Omar Ramirez Luna wrote: >> Some IP blocks might not be using/controlling more than one >> reset line, this check loosens the restriction to fully use >> hwmod framework for those drivers. >> >> E.g.: ipu has reset lines: mmu_cache, cpu0 and cpu1. >> - cpu1 might not be used and hence (with previous check) >> won't be fully enabled by hwmod code. > > You mean that you might have some case where you need to enable the > mmu_cache and cpu0 and thus deassert only the mmu/cpu0 while keeping the > cpu1 under reset? > > So the any_hardreset is indeed not appropriate in that case. > > In fact, since the hardreset cannot be handled at all by the hwmod fmwk, > I'm even wondering if we should take care of checking the state at all. > But as Paul stated, if was done due to the lack of understanding about > the diver usage, so maybe things will become clearer once we will have > that code available. > > So I guess that checking for all the lines for the hardreset state is > anyway already a first step toward a good understanding of the reset > need for the remote processors. > > The patch looks fine to me considering that we do not have a lot of > information about the usage :-( > > Maybe you could add more information in the changelog to explain the way > you are going to use the reset API. I'll add an updated description with more information. Thanks for the comments, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
