Hi Paul, On Wed, Jul 04, 2012 at 04:53:32AM -0600, Paul Walmsley wrote: > Hello Sakari, > > On Wed, 9 May 2012, Sakari Ailus wrote: > > > The OMAP 3630 has configuration how the ISP CSI-2 PHY pins are connected to > > the actual CSI-2 receivers outside the ISP itself. Allow changing this > > configuration from the ISP driver. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxx> > > just checking on this one. Any update? Not yet; I need to address Laurent's comments also. I might have time to do that during the next week. > A few comments: it would be nice to have some kerneldoc for this function. > Also it would be nice to use macros rather than the raw bitshifts in this > function. And one level of indentation can be saved if you bail out early > if the function is not running on a 3630. Thanks. I'll do the changes for the next version. Cheers, -- Sakari Ailus e-mail: sakari.ailus@xxxxxx jabber/XMPP/Gmail: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
