Hi Paul, [...] > > > On Wed, Aug 08, 2012 at 19:35:50, Paul Walmsley wrote: > > > > > > > It doesn't seem to me that this would necessarily always be an error. > > > > Suppose some init code to create cpsw devices is running on an OMAP3430. > > > > Then a omap_hwmod_for_each_by_class() that doesn't locate anything > > > > wouldn't be an error, right? > > > > > > Well, I think a failed lookup operation will be a bit expensive since it > > > iterates over the whole list of registered hwmods and hence put in the > > > pr_err(). > > > > If performance is a serious problem there, we can maintain a list of hwmod > > pointers inside each struct omap_hwmod_class, updated when the hwmods are > > registered. But as far as I know, performance hasn't been an issue here > > yet. If performance is the real motivation, I'd rather see an > > implementation of per-class lists as described above. > > > > Ok. I'll try to do some profiling using a timer to see how much time we > spend over here. On AM335x there are 2 such lookups, one for the dma > and one for the mcbsp. I could get this done today but will get to it > tomorrow. Based on how this goes I'll try out the omap_hwmod_class list > like you suggested. > I used a dmtimer clocked at 24MHz (41ns resolution) to get the time spent in the lookup. There are two failed lookups that happen in AM335x and following are the times taken Run1 Lookup for dma - 435 cycles -> 17.835 usecs Lookup for mcbsp - 83 cycles -> 3.4 usecs Run2 Lookup for dma - 503 cycles -> 20.623 usecs Lookup for mcbsp - 90 cycles -> 3.69 usescs Run3 Lookup for dma - 375 cycles -> 15.375 usecs Lookup for mcbsp - 91 cycles -> 3.731 usecs The 2nd lookup happens immediately after the 1st one so probably the difference is coming due to the data sitting in the cache? The average times don't look too high to me but I guess you already knew that ;) If you are ok with a pr_debug() instead of a pr_err() I'll resubmit the patch with this change. Regards, Vaibhav B. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
