On 3 August 2012 00:24, Vaibhav Hiremath <hvaibhav@xxxxxx> wrote: > On 8/3/2012 3:50 AM, Omar Ramirez Luna wrote: >> So in _enable: >> >> _enable_clocks(oh); >> if (soc_ops.enable_module) >> soc_ops.enable_module(oh); >> >> The enable_module part seems redundant to me, since the module should >> be already enabled by the first call to _enable_clocks. > > Yes they do same thing, I believe the plan is to get rid of all clock > leaf-nodes in the near future, and let hwmod handle module > enable/disable part. If this is the case then an enable_module call is needed in my patch for when these changes are made. The original works fine but only because currently clock framework does what enable_module is doing. Paul, Please let me know if you want me to resend with this change. Regards, Omar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
