Igor Grinberg <grinberg@xxxxxxxxxxxxxx> writes: > On 07/26/12 22:30, Kevin Hilman wrote: >> + Zumeng Chen >> >> Igor Grinberg <grinberg@xxxxxxxxxxxxxx> writes: >> >>> Hi Kevin, >>> >>> I've just noticed that the patch has been modified by Arnd in a way >>> that of course will trigger GPIO use without being requested. >>> I'm sorry, I was not available by that time Arnd changed the patch. >> >> Your right, your original patch isn't the problem. I found the root >> cause. >> >> The real problem is actually introduced by the merge of your patch from >> the arm-soc/cleanup branch, and this one from Zumeng Chen: commit >> 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce time for >> ads7846) from the arm-soc/boards branch. >> >> However, looking closer at the one from Zumeng, that one is clearly not >> right. It unconditionally adds a *board-specific* ->get_pendown_state >> function to the pdata that is common to *all* boards. That's just wrong >> and has the side-effect of making ->get_pendown_state() wrong on every >> board except the OMAP3EVM. Oops. >> >> So, IMO, in addition to $SUBJECT patch, in order to get the touchscreen >> GPIO working on non OMAP3EVM boards, we also need something like this as >> well. >> >> Igor, Zumeng, could you try this out on your boards anc confirm if it's >> working? I currently don't have a board setup with a touchscreen in my >> board farm. >> >> Kevin >> >>>From 85516c6a3354967caf4cff434d28c3001cd411eb Mon Sep 17 00:00:00 2001 >> From: Kevin Hilman <khilman@xxxxxx> >> Date: Thu, 26 Jul 2012 12:15:38 -0700 >> Subject: [PATCH 2/2] ARM: OMAP2+: ads7846: fix ->get_pendown_state() to work >> on all boards >> >> commit 16aced80f6 (ARM: OMAP3530evm: set pendown_state and debounce >> time for ads7846) introduced a common ->get_pendown_state() function >> into the generic code, but that function was board-specific for the >> OMAP3EVM. >> >> Fix this up to work for all boards that pass in a pendown GPIO. >> >> Cc: Zumeng Chen <zumeng.chen@xxxxxxxxxxxxx> >> Cc: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> >> Signed-off-by: Kevin Hilman <khilman@xxxxxx> > > Tested-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> Thanks to both of you for testing, I've updated the branch to include the tags, and will submit during the v3.6-rc cycle. Thanks, Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
