Mark, On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote: > On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote: > > Fixes below build error if CONFIG_REGULATOR is not enabled. > > > > drivers/built-in.o: In function `tps65217_probe': > > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match' > > This isn't a patch to the regulator driver, this is a patch to the MFD. > Normally this would be fixed by making the MFD driver not depend on the > regulator API - why is the MFD driver using the regulator API? > Regulators platform data is added to platform device in MFD driver, which we need for regulator driver, of_regulator_match() is used to check the regulator consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then of_regulator_match() is not exported, so we see this error. Regards AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html