Tony Lindgren <tony@xxxxxxxxxxx> writes: > * Kevin Hilman <khilman@xxxxxx> [120706 11:25]: >> The EHCI driver is not stable enough to be enabled by default. In v3.5, >> it has at least the following problems: >> >> - warning dump during bootup >> - hang during suspend >> - prevents CORE powerdomain from entering retention during idle (even >> when no USB devices connected.) >> >> This demonstrates that this driver has not been thoroughly tested and >> therfore should not be enabled in the default defconfig. >> >> In addition, the problems above cause new PM regressions which need be >> addressed before this driver should be enabled in the default >> defconfig. >> >> Signed-off-by: Kevin Hilman <khilman@xxxxxx> >> --- >> Tony, this applies to your current fixes branch. Please queue up for v3.5-rc >> so this PM regression is fixed in v3.5. Thanks. > > OK adding, Thanks. > although I don't like the idea of having to disable drivers in the > defconfig to fix issues :( Neither do I, that's why I've been complaining about it since v3.5 came out so it would be properly addressed by the driver writers. It hasn't, so this is the last resort. > The hang during suspend case would > be potentially hit by many people.. Should the driver/usb/host/ehci-omap.c > be patched to disable suspend or at least warn about it? Russ Dill has posted fixes already for several of the problems, and Keshava has posted a revert, but I don't see them beling addressed for v3.5. However, those fixes still don't address the CORE retention in idle issue which breaks PM for the whole SoC, so IMO this driver is still not ready to be enabled by default. Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
