Hi Franky, On 06/27/2012 08:03 PM, Franky Lin wrote: > On 06/27/2012 04:43 PM, Jon Hunter wrote: >> Hi Franky, >> >> On 06/25/2012 03:52 PM, Franky Lin wrote: >>> Hi Kevin, Tarun, >>> >>> We are using the expansion connector A on Panda board to mount a SDIO >>> WiFi dongle on MMC2 with a level triggered interrupt signal connected to >>> GPIO 138. It's been working fine until 3.5 rc1. The board hang randomly >>> within 5 mins during a network traffic test. After bisecting we found >>> the culprit is "[PATCH 8/8] gpio/omap: fix missing check in >>> *_runtime_suspend()" [1]. >> >> I have been looking into this today to see if I can replicate the >> problem that you have reported. However, so far I have not had any luck. >> Please note that my test setup is not exactly the same as yours as I >> don't have your wlan module. However, I have been using a 2nd board to >> generate gpio events to a panda-es to see I can make it lock up. I have >> tried mainline kernel 3.5-rc1 and 3.5-rc3 but I have not seen any >> problems after sending 100k gpio events (over many minutes). My setup is >> as follows ... >> >> - OMAP4460 panda-es with gpio-138 connected to OMAP3430 beagle gpio-11. >> - Mainline kernel 3.5-rc1/3 using omap2plus_defconfig (no changes) >> - Created a simple kernel module that acquires gpio-138 and sets up a >> IRQ with flag IRQF_TRIGGER_HIGH (for active high level interrupt). >> - GPIO events are triggered roughly every 1ms > > Don't know if it's related, but we also mux several other pins on > connector A: > /* MMC2 Mux for extension board */ > /* MMC2 CMD */ > OMAP4_MUX(GPMC_NWE, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > /* MMC2 CLK */ > OMAP4_MUX(GPMC_NOE, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > /* MMC2 DAT 0-3 */ > OMAP4_MUX(GPMC_AD0, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > OMAP4_MUX(GPMC_AD1, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > OMAP4_MUX(GPMC_AD2, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > OMAP4_MUX(GPMC_AD3, OMAP_MUX_MODE1 | OMAP_PIN_INPUT_PULLUP), > /* GPIO MUX for OOB interupt of dongle */ > OMAP4_MUX(MCSPI1_CS1, OMAP_MUX_MODE3 | OMAP_PIN_INPUT_PULLDOWN), > /* GPIO MUX for WLAN_ENABLE for dongle */ > OMAP4_MUX(MCSPI1_CLK, OMAP_MUX_MODE3 | OMAP_PIN_OUTPUT), I would not have thought so. However, I will think about that thanks. >> Can you confirm ... >> 1. You are just using omap2plus_defconfig with no changes? > No, we enable following options > CONFIG_DEVTMPFS=y > CONFIG_DEVTMPFS_MOUNT=y > CONFIG_USB_OHCI_HCD=y Ok, thanks. >> 2. Rough frequency of gpio events? > 3367 interrupts were triggered during a 10 secs throughput test. > >> 3. Is the gpio configured for active low or high? > active high > >> 4. When the hang occurs, what is the state of the gpio? Active or >> inactive? Can you probe it with a scope? If it was always active I >> could see that this would lock the device up, but I am not sure how >> that would relate to the results from your bisect??? > > I dont have a scope nearby. Let me see if I can find one tomorrow. Great, that would be good. >>> I noticed Kevin raised some similar cases on other platforms and also >>> provided two patches in the patch mail thread. But unfortunately those >>> two patches doesn't help in our case. I tested the driver with 3.5-rc3 >>> mainline kernel and the issue is still there. I can only "fix" the hang >>> by either reverting the commit or disabling CONFIG_PM_RUNTIME. Also, the >>> hang only happens on Panda ES board. Old Panda with 4430 works good. >> >> It does not make sense to me yet why this would only impact 4460, but I >> will keep this in mind. >> >> In your wlan driver are you acquiring and freeing the gpio often? Or are >> you only acquiring the gpio on boot? >> >> The reason I ask is because for omap4, it seems that we are not >> currently calling omap2_gpio_prepare_for_idle() during idle and so the >> only time I see us call the runtime_suspend/resume handlers for omap4 is >> during probe and when we acquire and free the gpio. >> >> So if you were not acquiring and freeing the gpio and are using the >> stock kernel, then as far as I can tell, the runtime pm code is not >> being exercised much. My test is not acquiring and releasing the gpio >> and so I am wondering if that is the secret to reproducing this >> problem :-) > > We only request the irq once during initialization. But we do frequently > disable and re-enable it since we need to access to the module through > SDIO to clear the interrupt. Apparently we can't finish all this in irq > handler. Ok, thanks. I don't see why that would cause a problem, but I can try that too. > Hope these could help. Yes, good info to have. Thanks Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
