Hi Afzal, On 06/26/2012 09:39 AM, Jon Hunter wrote: > Hi Afzal, > > On 06/26/2012 03:29 AM, Mohammed, Afzal wrote: >> Hi Jon, >> >> On Mon, Jun 25, 2012 at 21:42:14, Hunter, Jon wrote: >>> On 06/22/2012 04:01 AM, Afzal Mohammed wrote: >> >>>> +static int hf, vhf, sync_read, sync_write, latency; >>> >>> I am wondering if we can remove hf, vhf, sync_read/write variables >>> completely. We already have flags from sync_read/write and so we could >>> just use the cfg->flags variable and remove sync_read/write variables. >> >> For default frequency, sync_write can get turned off, so flag may or >> may not be same as sync_write > > Good point. I missed that. > >>> >>> At the same time, we could create flags for ONENAND_FREQ_HF and >>> ONENAND_FREQ_VHF or something like that. It could be nice to store the >>> latency in onenand_data too. In other words, keep all the configuration >>> in one place. >> >> I have a feeling as though platform data fields should not be altered once >> platform device is registered (as platform data being specific to the >> board, thinking further, should they be const?, except for a case >> where it is created by a common helper function for multiple boards with >> varying capabilities of peripheral). >> >> Other than sync_read, all others like hf, vhf, latency, sync_write are >> updated during driver callback, so if we are going to put these in >> platform private data fields, platform private data fields has to be >> updated after platform device is registered. > > May be this is splitting hairs then but I wonder if we should just have > a single global variable called onenand_flags for storing the current > state of sync_read, sync_write, vhf and hf. At least this would be only > one global instead of 4. Not a big deal. Apart from the above minor nit-pick, please add ... Reviewed-by: Jon Hunter <jon-hunter@xxxxxx> Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
