Hi Afzal, Looks much better! On 06/22/2012 04:01 AM, Afzal Mohammed wrote: > Reorganize gpmc-onenand initialization so that changes > required for gpmc driver migration can be made smooth. > > Ensuring sync read/write are disabled in onenand cannot > be expected to work properly unless GPMC is setup, this > has been removed. > > Refactor set_async_mode & set_sync_mode functions to > separate out timing calculation & actual configuration > (GPMC & OneNAND side). > > Thanks to Jon for his suggestions. > > Signed-off-by: Afzal Mohammed <afzal@xxxxxx> > --- > > v4: > Reorganize set_sync/async functions in a better way > v3: > Refactor set_sync/async functions to separate out timing and > configurations > v2: > Move ensuring that async mode in OneNAND has been setup from > set_sync to setup function, improve commit message > > arch/arm/mach-omap2/gpmc-onenand.c | 153 +++++++++++++++++++----------------- > 1 file changed, 83 insertions(+), 70 deletions(-) > > diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c > index 8863e0a..878182b 100644 > --- a/arch/arm/mach-omap2/gpmc-onenand.c > +++ b/arch/arm/mach-omap2/gpmc-onenand.c > @@ -15,6 +15,7 @@ > #include <linux/platform_device.h> > #include <linux/mtd/onenand_regs.h> > #include <linux/io.h> > +#include <linux/err.h> > > #include <asm/mach/flash.h> > > @@ -25,6 +26,7 @@ > > #define ONENAND_IO_SIZE SZ_128K > > +static int hf, vhf, sync_read, sync_write, latency; I am wondering if we can remove hf, vhf, sync_read/write variables completely. We already have flags from sync_read/write and so we could just use the cfg->flags variable and remove sync_read/write variables. At the same time, we could create flags for ONENAND_FREQ_HF and ONENAND_FREQ_VHF or something like that. It could be nice to store the latency in onenand_data too. In other words, keep all the configuration in one place. Otherwise looks good. Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
