On Tuesday 26 June 2012 11:38 AM, Shubhrajyoti wrote: > On Monday 25 June 2012 06:00 PM, Felipe Balbi wrote: >>> Cc: Kevin Hilman <khilman@xxxxxx> >>>> Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> >> how will this ever work with DT ? > What you say makes sense however that is what currently > most of the omap drivers do. > > Will check on this. >> I say we get rid of the OMAP-specific >> API and build this "context lost" status directly on dev_pm_info and >> have something like pm_runtime_lost_context() or something with pm QoS >> tell you if a device has lost its context. >> >> Also, your commit log doesn't really state any problems you might have >> reached before, Didnt see any issues while reviewing found that the restore was done always. >> or any improvements wrt latency coming out of suspend >> and so on. I am only restoring only 4-5 registers. >> >> IMHO, drivers need a generic way to differentiate if they're resuming >> from OFF or RET, otherwise we will end up with a bunch of OMAP-specific >> hackery on all drivers > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html