Hi Jon,
On Wed, Jun 13, 2012 at 21:01:08, Hunter, Jon wrote:
> On 06/11/2012 09:27 AM, Afzal Mohammed wrote:
> > +static __devinit int gpmc_setup_cs(struct gpmc_peripheral *g_per,
> > + struct gpmc_cs_data *cs, struct resource *res) {
> > + int num, ret;
> > +
> > + num = gpmc_setup_cs_mem(cs, res);
> > + if (IS_ERR_VALUE(num))
> > + return num;
> > +
> > + ret = gpmc_setup_cs_config_timing(g_per, cs);
> > + if (IS_ERR_VALUE(ret))
> > + return ret;
> > +
> > + num += gpmc_setup_cs_irq(cs, res + num);
>
>
> What happens if the above function returns an error?
That has been deliberately done as that implies user has not
specified irq flag & hence is not an error.
But it seems, I should print error information if user tries to use an
interrupt and if driver does not want/unable to use gpmc interrupt.
Regards
Afzal
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
