Re: [PATCH] ASoC: omap-mcbsp: Add pm_runtime_get/put functions call for McBSP.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 01, 2012 at 10:12:52PM +0200, Sebastien Guiriec wrote:
> pm_runtime_get_sync() and put_sync() are not called by McBSP driver.
> This is introducing a problem with PM and Audio Backend due to
> missing get/put for McBSP IP.

They are called by the core.  Probably you're just pointing your struct
device at some virtual device instead of the physical device, either
enabling runtime PM for the virtual device (assuming it's a child of the
physical device) or changing the pointer to the physical device (which
might make for better dev_ logging potentially) should resolve the
issue.

> +       pm_runtime_put_sync(mcbsp->dev);

No need for this, anyway - just use regular _put().  We don't care if
the device is actually suspended before we return, the PM core can do
that at it's leisure.

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux