On 16:27-20120531, Kevin Hilman wrote: > Nishanth Menon <nm@xxxxxx> writes: > > > Currently we check against the entire 32 bits of the status register > > Where, bits 1-31 are marked as reserved and mentioned in TRM as read > > returns undefined values. > > ouch > > > Hence, check against purely the vpinidle status bit. > > > > Cc: Tony Lindgren <tony@xxxxxxxxxxx> > > Cc: Kevin Hilman <khilman@xxxxxx> > > Cc: linux-omap@xxxxxxxxxxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > > > Reported-by: Vinay Amancha <vinaykumar@xxxxxx> > > Signed-off-by: Nishanth Menon <nm@xxxxxx> > > Thanks for the fix. > > Looking at this combined with the previous patches, since this same > thing is done several places, it looks like we need a helper function > 'omap_vp_wait_for_idle()' or similar. That function will do the check, > wait for timeout, and return an error if failure. The callers can than > do appropriate error handling upon failure. > yep - i think a static inline should do just fine here considering just a test_timeout is involved. will post out a new series in a few mins. -- Regards, Nishanth Menon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
