On 05/25/2012 05:42 AM, jgq516@xxxxxxxxx wrote: > From: Xiao Jiang <jgq516@xxxxxxxxx> > > Add device table for omap_wdt to support dt. > > Signed-off-by: Xiao Jiang <jgq516@xxxxxxxxx> > --- > drivers/watchdog/omap_wdt.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/drivers/watchdog/omap_wdt.c b/drivers/watchdog/omap_wdt.c > index 8285d65..d98c615 100644 > --- a/drivers/watchdog/omap_wdt.c > +++ b/drivers/watchdog/omap_wdt.c > @@ -430,6 +430,13 @@ static int omap_wdt_resume(struct platform_device *pdev) > #define omap_wdt_resume NULL > #endif > > +static const struct of_device_id omap_wdt_of_match[] = { > + { .compatible = "ti,omap3-wdt", }, > + { .compatible = "ti,omap4-wdt", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, omap_wdt_of_match); > + > static struct platform_driver omap_wdt_driver = { > .probe = omap_wdt_probe, > .remove = __devexit_p(omap_wdt_remove), > @@ -439,6 +446,7 @@ static struct platform_driver omap_wdt_driver = { > .driver = { > .owner = THIS_MODULE, > .name = "omap_wdt", > + .of_match_table = omap_wdt_of_match, > }, > }; > I think we need to add some code to the probe function that calls of_match_device() and ensures we find a match. For example ... if (of_have_populated_dt()) if (!of_match_device(omap_wdt_of_match, &pdev->dev)) return -EINVAL; Cheers Jon -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html