On Fri, May 11, 2012 at 00:00:25, Tony Lindgren wrote: > * Hiremath, Vaibhav <hvaibhav@xxxxxx> [120510 11:22]: > > On Thu, May 10, 2012 at 23:35:36, Tony Lindgren wrote: > > > * Tony Lindgren <tony@xxxxxxxxxxx> [120510 11:06]: > > > > * Tony Lindgren <tony@xxxxxxxxxxx> [120509 11:58]: > > > > > * Vaibhav Hiremath <hvaibhav@xxxxxx> [120509 04:28]: > > > > > > Initially, we decided to make am33xx family of device to fall > > > > > > under omap3 class (cpu_is_omap34xx() = true), since it carries > > > > > > Cortex-A8 core. But while adding complete baseport support > > > > > > (like, clock, power and hwmod) support, it is observed that, > > > > > > we are creating more and more problems by treating am33xx device > > > > > > as omap3 family, as nothing matches between them > > > > > > (except cortex-A8 mpu). > > > > > > > > > > Thanks applying into devel-soc after updating for soc_is change > > > > > and fixing typo in the description that stil said OMAPAM. Updated > > > > > patch below. > > > > > > > > Turns out we still need to add defined(CONFIG_SOC_AM33XX) around > > > > __omap2_set_globals() to keep compile working when omap4 + am33xx > > > > are selected without omap2 or 3. Also removed the "default y" > > > > for am33xx as that's where we're heading to anyways. > > > > > > > > Updated patch below. > > > > > > Argh, now it breaks with: > > > > > > arch/arm/mach-omap2/built-in.o: In function `omap2_set_globals_am33xx': > > > twl-common.c:(.init.text+0x1dd8): undefined reference to `omap2_set_globals_sdrc' > > > > > > There are clearly some dependencies to the clean up patches being > > > discussed.. So I'll drop this for now until the clean up is sorted > > > out. > > > > > > > All cleanup patches which I have posted should resolve these issues. > > Do you see any issues with them? > > > > ARM: OMAP2+: CLEANUP: All OMAP2PLUS uses omap-device.o target so add > > one entry > > That looks OK to me. > > > ARM: OMAP2+: CLEANUP: Move omap3 dpll ops to dpll3xxx.c > > This one should be at least acked by Paul. > > > ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around > > __omap2_set_globals > > This one should be acked by both Paul and Kevin. > > > You can only drop last patch, on which Kevin had commented, rest all should > > be merged. > > > > ARM: OMAP2+: CLEANUP: Add new config option for different DPLL > > Features > > > > > > Please let me know if I am missing something. > > Looks OK otherwise, just can't quite apply them yet without the acks. > Understood. Let's wait for Kevin and Paul's ack on this. I will ping them tomorrow again... Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
