Hi J, > why do you duplicate this >> + break; >> + case 1: >> + omap_revision = OMAP5430_REV_ES2_0; >> + break; > do this > > case 0: >> + default: >> + omap_revision = OMAP5430_REV_ES1_0; >> + } >> + break; >> + >> + case 0xb998: >> + switch (rev) { >> + case 0: >> + omap_revision = OMAP5432_REV_ES1_0; >> + break; >> + default: > ditto here Agree. Will correct the redundancy. Thanks, Sricharan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html