Re: omapfb-main.c: check result of simple_strtoul

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-05-09 at 22:47 +0800, Hein Tibosch wrote:
> Tomi,
> 
> 
> In drivers/video/omap2/omapfb/omapfb-main.c:
> 
>  static int omapfb_parse_vram_param(const char *param, int max_entries,
>  		unsigned long *sizes, unsigned long *paddrs)
>  {
>  	int fbnum;
>  	unsigned long size;
>  	unsigned long paddr = 0;
>  	char *p, *start;
>   	start = (char *)param;
>  	while (1) {
>  		p = start;
>   		fbnum = simple_strtoul(p, &p, 10);
> -		if (p == param)
> +		if (p == start)
> 
> correct?

Yes, looks like a correct fix. I'll cook up a patch.

How did you encounter the bug? What was the outcome?

 Tomi

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux