Re: [PATCH] ARM: OMAP2+: remove incorrect irq_chip ack field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Grazvydas Ignotas <notasas@xxxxxxxxx> [120505 17:00]:
> Each irq_chip for the main interrupt controller has offsets set for irq
> masking registers, which added to respective base results in a pointer
> to appropriate hardware register. However this is not correct for
> INTC_CONTROL as there is only one INTC_CONTROL register. This does not
> cause problems because generic ack code is never called, but remove
> this assignment to avoid confusion.

Thanks applying into fixes-non-critical.

Regards,

Tony
 
> Signed-off-by: Grazvydas Ignotas <notasas@xxxxxxxxx>
> ---
>  arch/arm/mach-omap2/irq.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c
> index 65f0d25..c11e8a8 100644
> --- a/arch/arm/mach-omap2/irq.c
> +++ b/arch/arm/mach-omap2/irq.c
> @@ -149,7 +149,6 @@ omap_alloc_gc(void __iomem *base, unsigned int irq_start, unsigned int num)
>  	ct->chip.irq_mask = irq_gc_mask_disable_reg;
>  	ct->chip.irq_unmask = irq_gc_unmask_enable_reg;
>  
> -	ct->regs.ack = INTC_CONTROL;
>  	ct->regs.enable = INTC_MIR_CLEAR0;
>  	ct->regs.disable = INTC_MIR_SET0;
>  	irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE,
> -- 
> 1.7.0.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux