Vaibhav Hiremath <hvaibhav@xxxxxx> writes: > The function __omap2_set_globals() can be common across all > platforms/architectures, even in case of omap4, internally it > calls same set of functions as in __omap2_set_globals() function > (except for sdrc). OK so far. > This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle sdrc, > so that we can reuse same function across omap2/3/4... But what happens when a single kernel is built that has support for an SoC with an SDRC (OMAP4) and one that doesn't (AM33xx)? In that case this new SOC_HAS_OMAP2_SDRC will be set, and set_globals_sdrc() will be called even for the SoCs without SDRC. So, rather than add a new Kconfig option for this, I would rather see you using the existing runtime feature check for the SDRC: omap_has_sdrc() Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
